linux-kernel - Re: [PATCH v3 1/1] rtc: rx6110: add ACPI bindings to I2C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 16 Mar 2021 13:33:01 +0200
From:   Andy Shevchenko <andriy.shevchenko@...el.com>
To:     Claudius Heine <ch@...x.de>
Cc:     johannes hahn <johannes-hahn@...mens.com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" 
        <linux-rtc@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        werner zeh <werner.zeh@...mens.com>,
        henning schild <henning.schild@...mens.com>,
        martin mantel <martin.mantel@...mens.com>,
        val krutov <val.krutov@....epson.com>
Subject: Re: [PATCH v3 1/1] rtc: rx6110: add ACPI bindings to I2C

On Tue, Mar 16, 2021 at 01:30:36PM +0200, Andy Shevchenko wrote:
> On Tue, Mar 16, 2021 at 11:08:05AM +0100, Claudius Heine wrote:
> > From: Johannes Hahn <johannes-hahn@...mens.com>
> > 
> > This allows the RX6110 driver to be automatically assigned to the right
> > device on the I2C bus.
> 
> Thanks for all effort!
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...el.com>
> after addressing the below comments.
> 
> > Signed-off-by: Johannes Hahn <johannes-hahn@...mens.com>
> > Signed-off-by: Claudius Heine <ch@...x.de>
> 
> > Signed-off-by: Henning Schild <henning.schild@...mens.com>
> 
> I think this is somehow confusing. Either you need to add Co-developed-by of
> the corresponding people, or remove SoB (because of From line), i.o.w seems
> like Co-dB tag is needed for Johannes or you and something should be done with
> Henning's SoB.

Since Johannes' name is in the From, then it seems okay for you (either you a
co-developer, than a Co-dB tag, or a submitter, than it's okay to have no Co-dB
tag).


-- 
With Best Regards,
Andy Shevchenko