linux-kernel - Re: [PATCH] thermal: power_allocator: using round the division when re-divvying up power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 16 Mar 2021 13:16:09 +0000
From:   Lukasz Luba <lukasz.luba@....com>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     gao.yunxiao6@...il.com, rui.zhang@...el.com, amitk@...nel.org,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        orsonzhai@...il.com, zhang.lyra@...il.com,
        "jeson.gao" <jeson.gao@...soc.com>
Subject: Re: [PATCH] thermal: power_allocator: using round the division when
 re-divvying up power



On 3/16/21 1:15 PM, Daniel Lezcano wrote:
> On 15/03/2021 10:51, Lukasz Luba wrote:
>>
>>
>> On 3/15/21 8:25 AM, gao.yunxiao6@...il.com wrote:
>>> From: "jeson.gao" <jeson.gao@...soc.com>
>>>
>>> The division is used directly in re-divvying up power, the decimal
>>> part will
>>> be discarded, devices will get less than the extra_actor_power - 1.
>>> if using round the division to make the calculation more accurate.
>>>
>>> For example:
>>> actor0 received more than it's max_power, it has the extra_power 759
>>> actor1 received less than it's max_power, it require extra_actor_power
>>> 395
>>> actor2 received less than it's max_power, it require extra_actor_power
>>> 365
>>> actor1 and actor2 require the total capped_extra_power 760
>>>
>>> using division in re-divvying up power
>>> actor1 would actually get the extra_actor_power 394
>>> actor2 would actually get the extra_actor_power 364
>>>
>>> if using round the division in re-divvying up power
>>> actor1 would actually get the extra_actor_power 394
>>> actor2 would actually get the extra_actor_power 365
>>>
>>> Signed-off-by: Jeson Gao <jeson.gao@...soc.com>
>>> ---
> 
> Applied, thanks
> 

thank you Daniel!