linux-kernel - Re: [PATCH] thermal: power_allocator: using round the division when re-divvying up power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 17 Mar 2021 19:20:43 +0800
From:   gao yunxiao <gao.yunxiao6@...il.com>
To:     Lukasz Luba <lukasz.luba@....com>
Cc:     Daniel Lezcano <daniel.lezcano@...aro.org>, rui.zhang@...el.com,
        amitk@...nel.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, orsonzhai@...il.com,
        zhang.lyra@...il.com, "jeson.gao" <jeson.gao@...soc.com>
Subject: Re: [PATCH] thermal: power_allocator: using round the division when
 re-divvying up power

Lukasz,Daniel, Thank you for your review!

On 16/03/2021, Lukasz Luba <lukasz.luba@....com> wrote:
>
>
> On 3/16/21 1:15 PM, Daniel Lezcano wrote:
>> On 15/03/2021 10:51, Lukasz Luba wrote:
>>>
>>>
>>> On 3/15/21 8:25 AM, gao.yunxiao6@...il.com wrote:
>>>> From: "jeson.gao" <jeson.gao@...soc.com>
>>>>
>>>> The division is used directly in re-divvying up power, the decimal
>>>> part will
>>>> be discarded, devices will get less than the extra_actor_power - 1.
>>>> if using round the division to make the calculation more accurate.
>>>>
>>>> For example:
>>>> actor0 received more than it's max_power, it has the extra_power 759
>>>> actor1 received less than it's max_power, it require extra_actor_power
>>>> 395
>>>> actor2 received less than it's max_power, it require extra_actor_power
>>>> 365
>>>> actor1 and actor2 require the total capped_extra_power 760
>>>>
>>>> using division in re-divvying up power
>>>> actor1 would actually get the extra_actor_power 394
>>>> actor2 would actually get the extra_actor_power 364
>>>>
>>>> if using round the division in re-divvying up power
>>>> actor1 would actually get the extra_actor_power 394
>>>> actor2 would actually get the extra_actor_power 365
>>>>
>>>> Signed-off-by: Jeson Gao <jeson.gao@...soc.com>
>>>> ---
>>
>> Applied, thanks
>>
>
> thank you Daniel!
>