linux-kernel - Re: [PATCH v4 RESEND net-next] net: socket: use BIT() for MSG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADxym3YKnwFce1D9w4xz83E8cRot1BMeTES8azJc1U3EJEeh7A@mail.gmail.com>
Date:   Wed, 17 Mar 2021 22:15:19 +0800
From:   Menglong Dong <menglong8.dong@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     Guenter Roeck <linux@...ck-us.net>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "axboe@...nel.dk" <axboe@...nel.dk>,
        "viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>,
        "herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
        "dong.menglong@....com.cn" <dong.menglong@....com.cn>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH v4 RESEND net-next] net: socket: use BIT() for MSG_*

On Wed, Mar 17, 2021 at 9:53 PM Menglong Dong <menglong8.dong@...il.com> wrote:
>
...
>
> Seems that the inconsistent usages of 'msg_flags' is a lot, for example the
> 'recvmsg()' in 'struct proto' and 'recvmsg()' in 'struct proto_ops':
>
> int (*recvmsg)(struct sock *sk, struct msghdr *msg,
>         size_t len, int noblock, int flags,
>         int *addr_len);
>
> This function prototype is used in many places, It's not easy to fix them.
> This patch is already reverted, and I think maybe
> I can resend it after I fix these 'int' flags.
>

I doubt it now...there are hundreds of functions that are defined as
'proto_ops->recvmsg()'.
enn...will this kind of patch be acceptable? Is it the time to give up?

With Best Regards,
Menglong Dong