linux-kernel - Re: [PATCH v5 00/17] Fix reset controls and RPM of NVIDIA Tegra ASoC drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <be93d088-fefe-77f0-9b8e-9c815cc0d0f0@gmail.com>
Date:   Wed, 17 Mar 2021 20:20:10 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Mark Brown <broonie@...nel.org>, Takashi Iwai <tiwai@...e.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Paul Fertser <fercerpav@...il.com>
Cc:     alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 00/17] Fix reset controls and RPM of NVIDIA Tegra ASoC
 drivers

14.03.2021 18:44, Dmitry Osipenko пишет:
> Hi,
> 
> This series adds missing hardware reset controls to I2S and AC97 drivers,
> corrects runtime PM usage and drivers probe/remove order. Currently drivers
> happen to work properly because reset is implicitly deasserted by tegra-clk
> driver, but clk driver shouldn't touch the resets and we need to fix it
> because this breaks other Tegra drivers. Previously we fixed the resets of
> the AHUB and HDMI codec drivers, but turned out that we missed the I2C and
> AC97 drivers.
> 
> Thanks to Paul Fertser for testing the pending clk patches and finding
> that audio got broken on Tegra20 AC100 netbook because of the missing I2S
> reset.
....
> Dmitry Osipenko (16):
>   ASoC: tegra20: ac97: Add reset control
>   ASoC: tegra20: i2s: Add reset control
>   ASoC: tegra30: i2s: Restore hardware state on runtime PM resume
>   ASoC: tegra30: ahub: Switch to use reset-bulk API
>   ASoC: tegra20: spdif: Correct driver removal order
>   ASoC: tegra20: spdif: Remove handing of disabled runtime PM
>   ASoC: tegra20: i2s: Add system level suspend-resume callbacks
>   ASoC: tegra20: i2s: Correct driver removal order
>   ASoC: tegra20: i2s: Use devm_clk_get()
>   ASoC: tegra20: i2s: Remove handing of disabled runtime PM
>   ASoC: tegra30: i2s: Correct driver removal order
>   ASoC: tegra30: i2s: Use devm_clk_get()
>   ASoC: tegra30: i2s: Remove handing of disabled runtime PM
>   ASoC: tegra30: ahub: Reset global variable
>   ASoC: tegra30: ahub: Correct suspend-resume callbacks
>   ASoC: tegra30: ahub: Remove handing of disabled runtime PM
> 
> Philipp Zabel (1):
>   reset: Add reset_control_bulk API

Mark / Takashi, I may try to split up this series into two or three
smaller patchsets and then the reset/ patch from Philipp Zabel could be
merged by Philipp himself. I primarily want to have the audio resets
fixed and the reset API extended with reset_control_bulk in 5.13 because
this will unblock other patches. Please let me know what you prefer more.