linux-kernel - Re: [PATCH] kernel: cpu: resctrl: Minor typo fix in the file pseudo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YFJZf0VvNf6Ndp+w@ArchLinux>
Date:   Thu, 18 Mar 2021 01:03:19 +0530
From:   Bhaskar Chowdhury <unixbhaskar@...il.com>
To:     Reinette Chatre <reinette.chatre@...el.com>
Cc:     fenghua.yu@...el.com, tglx@...utronix.de, mingo@...hat.com,
        bp@...en8.de, x86@...nel.org, hpa@...or.com,
        linux-kernel@...r.kernel.org, rdunlap@...radead.org
Subject: Re: [PATCH] kernel: cpu: resctrl: Minor typo fix in the file
 pseudo_lock.c

On 10:54 Wed 17 Mar 2021, Reinette Chatre wrote:
>Hi Bhaskar,
>
>Thank you very much for catching this typo.
>
>My feedback [1] to a previous patch from you applies here also. The
>prefix should be "x86/resctrl:" for contributions to this area.
>
Thanks for the heads up! Do you want another revision of it, or will you
take it as it is??? I am noting down your point ,so ,I might pull out next
time I intend to sent out something to this specific area.
>[1]
>https://lore.kernel.org/lkml/7e3a5c13-db5c-7399-2b80-f1284786ea77@intel.com/
>
>On 3/17/2021 1:40 AM, Bhaskar Chowdhury wrote:
>>
>> s/derefence/dereference/
>>
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@...il.com>
>> ---
>>   arch/x86/kernel/cpu/resctrl/pseudo_lock.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/kernel/cpu/resctrl/pseudo_lock.c b/arch/x86/kernel/cpu/resctrl/pseudo_lock.c
>> index e916646adc69..43990a882b36 100644
>> --- a/arch/x86/kernel/cpu/resctrl/pseudo_lock.c
>> +++ b/arch/x86/kernel/cpu/resctrl/pseudo_lock.c
>> @@ -1307,7 +1307,7 @@ int rdtgroup_pseudo_lock_create(struct rdtgroup *rdtgrp)
>>   		 * If the thread does not get on the CPU for whatever
>>   		 * reason and the process which sets up the region is
>>   		 * interrupted then this will leave the thread in runnable
>> -		 * state and once it gets on the CPU it will derefence
>> +		 * state and once it gets on the CPU it will dereference
>>   		 * the cleared, but not freed, plr struct resulting in an
>>   		 * empty pseudo-locking loop.
>>   		 */
>> --
>> 2.30.2
>>
>
>Reinette

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)