linux-kernel - Re: [PATCH 1/1] leds: lgm: Improve Kconfig help

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 18 Mar 2021 21:37:12 +0100
From:   Pavel Machek <pavel@....cz>
To:     Rahul Tanwar <rtanwar@...linear.com>
Cc:     Arnd Bergmann <arnd@...nel.org>,
        "linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Adam Borowski <kilobyte@...band.pl>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        John Crispin <john@...ozen.org>,
        Hauke Mehrtens <hmehrtens@...linear.com>,
        Cheol Yong Kim <ckim@...linear.com>,
        Qiming Wu <qwu@...linear.com>
Subject: Re: [PATCH 1/1] leds: lgm: Improve Kconfig help

Hi!


> >  > help
> >  > - Parallel to serial conversion, which is also called SSO
> >  > controller,
> >  > - can drive external shift register for LED outputs.
> >  > - This enables LED support for Serial Shift Output controller(SSO).
> >  > + This option enables support for LEDs connected to GPIO lines on
> >  > + Lightning Mountain(LGM) SoC. These LEDs are driven by a Serial
> >  > + Shift Output(SSO) controller. The driver supports hardware
> > 
> > What is Lightning Mountain? The codename is not widely known. Where
> > can we find that hardware? Notebooks? Phones? Only some development
> > boards?
> > 
> 
> Lightning Mountain is generically a network processor with a primary 
> targeted application as Gateway SoC. It has already been added as a 
> valid Intel Atom processor variant in 
> arch/x86/include/asm/intel-family.h as below:

Yep, but Kconfig users are not going to read header files.

If the SoC is not shipping in any products, state so.

> >  > *
> >  > - * Copyright (c) 2020 Intel Corporation.
> >  > + * Copyright (c) 2021 MaxLinear, Inc.
> >  > */
> >  >
> > 
> > I don't think you can do that, and I don't think you should be doing
> > it in the same patch.
> 
> Well noted. Will revert it back now and update later in a separate 
> patch. Thanks.

Don't. You can't update copyright like that.

								Pavel
-- 
http://www.livejournal.com/~pavelmachek

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)