linux-kernel - Re: [PATCH 1/1] leds: lgm: Improve Kconfig help

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MN2PR19MB3693318349FCCF3201E8EA80B1699@MN2PR19MB3693.namprd19.prod.outlook.com>
Date:   Thu, 18 Mar 2021 09:49:22 +0000
From:   Rahul Tanwar <rtanwar@...linear.com>
To:     Pavel Machek <pavel@....cz>
CC:     Arnd Bergmann <arnd@...nel.org>,
        "linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Adam Borowski <kilobyte@...band.pl>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        John Crispin <john@...ozen.org>,
        Hauke Mehrtens <hmehrtens@...linear.com>,
        Cheol Yong Kim <ckim@...linear.com>,
        Qiming Wu <qwu@...linear.com>
Subject: Re: [PATCH 1/1] leds: lgm: Improve Kconfig help

Hi Pavel,

On 18/3/2021 3:55 pm, Pavel Machek wrote:
> Hi!
> 
>  > Remove unnecessary Kconfig symbol LEDS_BLINK
>  > Improve Kconfig help text to make it more useful.
>  >
>  > Signed-off-by: Rahul Tanwar <rtanwar@...linear.com>
> 
>  > +++ b/drivers/leds/blink/Kconfig
>  > @@ -1,21 +1,19 @@
>  > -menuconfig LEDS_BLINK
>  > - bool "LED Blink support"
>  > - depends on LEDS_CLASS
>  > - help
>  > - This option enables blink support for the leds class.
>  > - If unsure, say Y.
>  > -
>  > -if LEDS_BLINK
>  > -
>  > -config LEDS_BLINK_LGM
>  > - tristate "LED support for Intel LGM SoC series"
>  > +config LEDS_LGM
>  > + tristate "LED support for LGM SoC series"
>  > depends on GPIOLIB
>  > depends on LEDS_CLASS
>  > depends on MFD_SYSCON
>  > depends on OF
>  > help
>  > - Parallel to serial conversion, which is also called SSO
>  > controller,
>  > - can drive external shift register for LED outputs.
>  > - This enables LED support for Serial Shift Output controller(SSO).
>  > + This option enables support for LEDs connected to GPIO lines on
>  > + Lightning Mountain(LGM) SoC. These LEDs are driven by a Serial
>  > + Shift Output(SSO) controller. The driver supports hardware
> 
> What is Lightning Mountain? The codename is not widely known. Where
> can we find that hardware? Notebooks? Phones? Only some development
> boards?
> 

Lightning Mountain is generically a network processor with a primary 
targeted application as Gateway SoC. It has already been added as a 
valid Intel Atom processor variant in 
arch/x86/include/asm/intel-family.h as below:

#define INTEL_FAM6_ATOM_AIRMONT_NP	0x75 /* Lightning Mountain */

Please see [1].


> If user is not likely to need the driver, say so.
> 
>  > + blinking with a configurable LED update/blink frequency in two
>  > + modes, 2/4/8/10 Hz in low speed mode and 50/100/200/250
>  > KHz in
> 
> kHz? But I guess we don't need that here.
>

Well noted. Will update in V2.


>  > *
>  > - * Copyright (c) 2020 Intel Corporation.
>  > + * Copyright (c) 2021 MaxLinear, Inc.
>  > */
>  >
> 
> I don't think you can do that, and I don't think you should be doing
> it in the same patch.


Well noted. Will revert it back now and update later in a separate 
patch. Thanks.


> 

Regards,
Rahul

[1] 
https://github.com/torvalds/linux/blob/master/arch/x86/include/asm/intel-family.h