linux-kernel - RE: [PATCH v3] ASoC: Intel: sof_rt5682: Add ALC1015Q-VB speaker amp support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7f91482a93aa4d429ee574d730eeca6a@realtek.com>
Date:   Thu, 18 Mar 2021 01:21:03 +0000
From:   Jack Yu <jack.yu@...ltek.com>
To:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Brent Lu <brent.lu@...el.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        kent_chen@...ltek.com [陳建宏] 
        <kent_chen@...ltek.com>
CC:     Oder Chiou <oder_chiou@...ltek.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        "Takashi Iwai" <tiwai@...e.com>,
        Cezary Rojewski <cezary.rojewski@...el.com>,
        Jie Yang <yang.jie@...ux.intel.com>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Guennadi Liakhovetski <guennadi.liakhovetski@...ux.intel.com>,
        Rander Wang <rander.wang@...ux.intel.com>,
        Yong Zhi <yong.zhi@...el.com>,
        Libin Yang <libin.yang@...ux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Sathyanarayana Nujella <sathyanarayana.nujella@...el.com>,
        Dharageswari R <dharageswari.r@...el.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        Fred Oh <fred.oh@...ux.intel.com>,
        Tzung-Bi Shih <tzungbi@...gle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3] ASoC: Intel: sof_rt5682: Add ALC1015Q-VB speaker amp support

> > This patch adds jsl_rt5682_rt1015p which supports the RT5682 headset
> > codec and ALC1015Q-VB speaker amplifier combination on JasperLake
> > platform.
> >
> > This driver also supports ALC1015Q-CG if running in auto-mode.
> > Following table shows the audio interface support of the two
> > amplifiers.
> >
> >            | ALC1015Q-CG | ALC1015Q-VB
> > =====================================
> > I2C       | Yes         | No
> > Auto-mode | 48K, 64fs   | 16k, 32fs
> >                          | 48k, 32fs
> >                          | 48k, 64fs
> >
> > Signed-off-by: Brent Lu <brent.lu@...el.com>
> 
> The code is looks fine, but Jack Yu added a separate patch that makes
> RTL1019 equivalent to RTL1015, so should this patch also handle the
> RTL1019 case?
> 
For rt1019 non-i2c mode (auto mode), it uses the sdb pin to enable amp, the same as rt1015 non-i2c mode,
therefore we propose rt1019(auto mode) to use rt1015p instead of adding a new driver for it.