[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3144b030-0f90-717b-b373-2d0b346010c8@intel.com>
Date: Fri, 19 Mar 2021 08:15:33 -0700
From: "Yu, Yu-cheng" <yu-cheng.yu@...el.com>
To: Borislav Petkov <bp@...en8.de>
Cc: x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>,
Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
linux-doc@...r.kernel.org, linux-mm@...ck.org,
linux-arch@...r.kernel.org, linux-api@...r.kernel.org,
Arnd Bergmann <arnd@...db.de>,
Andy Lutomirski <luto@...nel.org>,
Balbir Singh <bsingharora@...il.com>,
Cyrill Gorcunov <gorcunov@...il.com>,
Dave Hansen <dave.hansen@...ux.intel.com>,
Eugene Syromiatnikov <esyr@...hat.com>,
Florian Weimer <fweimer@...hat.com>,
"H.J. Lu" <hjl.tools@...il.com>, Jann Horn <jannh@...gle.com>,
Jonathan Corbet <corbet@....net>,
Kees Cook <keescook@...omium.org>,
Mike Kravetz <mike.kravetz@...cle.com>,
Nadav Amit <nadav.amit@...il.com>,
Oleg Nesterov <oleg@...hat.com>, Pavel Machek <pavel@....cz>,
Peter Zijlstra <peterz@...radead.org>,
Randy Dunlap <rdunlap@...radead.org>,
"Ravi V. Shankar" <ravi.v.shankar@...el.com>,
Vedvyas Shanbhogue <vedvyas.shanbhogue@...el.com>,
Dave Martin <Dave.Martin@....com>,
Weijiang Yang <weijiang.yang@...el.com>,
Pengfei Xu <pengfei.xu@...el.com>,
Haitao Huang <haitao.huang@...el.com>
Subject: Re: [PATCH v23 22/28] x86/cet/shstk: User-mode shadow stack support
On 3/19/2021 2:28 AM, Borislav Petkov wrote:
> On Thu, Mar 18, 2021 at 12:05:58PM -0700, Yu, Yu-cheng wrote:
>> Maybe I would add comments here.
>
> Yap.
>
> Also, looking forward in the set, I see prctl_set() and that is also
> done on current so should be ok.
>
> In any case, yes, documenting the assumptions and expectations wrt
> current here is a good idea.
>
>> If vm_munmap() returns -EINTR, mmap_lock is held by something else. That
>> lock should not be held forever. For other types of error, the loop stops.
>
> Ok I guess. The subsequent WARN_ON_ONCE() looks weird too but that
> should not fire, right? :)
>
> Thx.
>
That should not fire.
Yu-cheng
Powered by blists - more mailing lists