[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAD=FV=XdBOZYuCVUjhAnEu0sKOmEHaCpA69v=BjQoM9gGQFjTg@mail.gmail.com>
Date: Fri, 19 Mar 2021 16:10:43 -0700
From: Doug Anderson <dianders@...omium.org>
To: Kalyan Thota <kalyan_t@...eaurora.org>
Cc: y@...lcomm.com, dri-devel <dri-devel@...ts.freedesktop.org>,
linux-arm-msm <linux-arm-msm@...r.kernel.org>,
freedreno <freedreno@...ts.freedesktop.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
Rob Clark <robdclark@...il.com>, mkrishn@...eaurora.org,
Stephen Boyd <swboyd@...omium.org>
Subject: Re: [v1] drm/msm/disp/dpu1: fix display underruns during modeset.
Hi,
On Fri, Mar 19, 2021 at 5:54 AM Kalyan Thota <kalyan_t@...eaurora.org> wrote:
>
> During crtc disable, display perf structures are reset to 0
> which includes state varibles which are immutable. On crtc
> enable, we use the same structures and they don't refelect
> the actual values
>
> 1) Fix is to avoid updating the state structures during disable.
> 2) Reset the perf structures during atomic check when there is no
> modeset enable.
>
> Signed-off-by: Kalyan Thota <kalyan_t@...eaurora.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 1 -
> drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 1 +
> 2 files changed, 1 insertion(+), 1 deletion(-)
I think Stephen was the one who originally noticed this and reported it, so:
Reported-by: Stephen Boyd <swboyd@...omium.org>
Seems to work for me. I got into the state where it was doing a
modeset at reboot (could see the underflow color for a period of time
when this happened). I added your patch and it looks better.
Tested-by: Douglas Anderson <dianders@...omium.org>
Powered by blists - more mailing lists