linux-kernel - Re: linux-next: Tree for Mar 19

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210320162734.1630cc55@elm.ozlabs.ibm.com>
Date:   Sat, 20 Mar 2021 16:27:34 +1100
From:   Stephen Rothwell <sfr@...hwell.id.au>
To:     Heiko Carstens <hca@...ux.ibm.com>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Alex Gaynor <alex.gaynor@...il.com>,
        Geoffrey Thomas <geofft@...reload.com>,
        Finn Behrens <me@...enk.de>,
        Wedson Almeida Filho <wedsonaf@...gle.com>,
        Adam Bratschi-Kaye <ark.email@...il.com>,
        Miguel Ojeda <ojeda@...nel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        Daniel Axtens <dja@...ens.net>
Subject: Re: linux-next: Tree for Mar 19

Hi all,

On Fri, 19 Mar 2021 15:30:31 +0100 Heiko Carstens <hca@...ux.ibm.com> wrote:
>
> This breaks now on s390 with commit 8ef6f74a3571 ("Rust support").
> make modules_install / depmod now fails with:
> 
> depmod: WARNING: /.../lib/modules/5.12.0-rc3-00001-g8ef6f74a3571/kernel/drivers/s390/scsi/zfcp.ko needs unknown symbol
> 
> for every module (yes, the line is complete).

Daniel Axtens reported the same breakage on powerpc.  I bisected it to
the same commit.  More experimentation shows that if you reverse just
the change to include/linux/moduleparam.h the above warnings go away.
So

-#define MAX_PARAM_PREFIX_LEN (256 - sizeof(unsigned long))
+#define MAX_PARAM_PREFIX_LEN (64 - sizeof(unsigned long))

fixes it up.  Not sure what that does to the rust support ...
-- 
Cheers,
Stephen Rothwell