linux-kernel - Re: [PATCH v5 3/3] ARM: imx7d-remarkable2.dts: Initial device tree for reMarkable2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKmqyKOxnXb5Pvbs=ikm_YqvRHrC03s3QU51cfwpw9C4+EWQFw@mail.gmail.com>
Date:   Sat, 20 Mar 2021 21:40:05 -0400
From:   Alistair Francis <alistair23@...il.com>
To:     Marco Felsch <m.felsch@...gutronix.de>
Cc:     Alistair Francis <alistair@...stair23.me>,
        Arnd Bergmann <arnd@...db.de>, Olof Johansson <olof@...om.net>,
        Rob Herring <robh+dt@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Sascha Hauer <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 3/3] ARM: imx7d-remarkable2.dts: Initial device tree
 for reMarkable2

On Fri, Mar 19, 2021 at 9:06 AM Marco Felsch <m.felsch@...gutronix.de> wrote:
>
> Hi Alistair,
>
> the patch looks quite good only a few notes inline.
>
> PS: It would be cool to have a log to previous patch versions.

I'm not sure how I could add that, I will add a changelog for this
version though.

>
> On 21-03-15 22:27, Alistair Francis wrote:
>
> ...
>
> > +&crypto {
> > +     status = "disabled";
> > +};
>
> Why do you disable the crypto subsystem?
>
> > +&dma_apbh {
> > +     status = "disabled";
> > +};
>
> Why do you disable this dma controller?
>
> > +
> > +&sdma {
> > +     status = "okay";
> > +};
>
> This is the default state so you can drop this node.

You are right, these are all just left over from the vendor DT, I have
removed all 3.

Alistair

>
> Regards,
>   Marco