linux-kernel - Re: [PATCH v5 3/3] ARM: imx7d-remarkable2.dts: Initial device tree for reMarkable2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 21 Mar 2021 10:15:14 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     Alistair Francis <alistair@...stair23.me>
Cc:     Arnd Bergmann <arnd@...db.de>, Olof Johansson <olof@...om.net>,
        Rob Herring <robh+dt@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Sascha Hauer <kernel@...gutronix.de>,
        NXP Linux Team <linux-imx@....com>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>, alistair23@...il.com
Subject: Re: [PATCH v5 3/3] ARM: imx7d-remarkable2.dts: Initial device tree
 for reMarkable2

Hi Alistair,

On Mon, Mar 15, 2021 at 11:27 PM Alistair Francis
<alistair@...stair23.me> wrote:
>
> The reMarkable2 (https://remarkable.com) is an e-ink tablet based on
> the imx7d SoC.
>
> This commit is based on the DTS provide by reMarkable but ported to the
> latest kernel (instead of 4.14). I have removed references to
> non-upstream devices and have changed the UART so that the console can
> be accessed without having to open up the device via the OTG pogo pins.
>
> Currently the kernel boots, but there is no support for the display.
>
> WiFi is untested (no dispaly or UART RX makes it hard to test), but

"display"

> +       memory {
> +               reg = <0x80000000 0x40000000>;
> +       };

This should be:

memory@...00000 {
         device_type = "memory";
         reg = <0x80000000 0x40000000>;
};

> +&crypto {
> +       status = "disabled";
> +};

Why do you need to disable this node?

> +&dma_apbh {
> +       status = "disabled";
> +};

Same here.

> +&sdma {
> +       status = "okay";
> +};

No need to enable it in the board file.

> +&iomuxc_lpsr {
> +       pinctrl_digitizer_reg: digitizerreggrp {

This is not referenced from anywhere.