linux-kernel - Re: Bootconfig ..too many deep level of header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20210321221753.5cc974f0d4cb8a1ed65c675f@kernel.org>
Date:   Sun, 21 Mar 2021 22:17:53 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Bhaskar Chowdhury <unixbhaskar@...il.com>
Cc:     LinuxKernel <linux-kernel@...r.kernel.org>
Subject: Re: Bootconfig ..too many deep level of header file

Hi Bhaskar,

On Sun, 21 Mar 2021 08:38:56 +0530
Bhaskar Chowdhury <unixbhaskar@...il.com> wrote:

>  Hey, Masami
> 
>  I was wondering why so many level of "deep nesting" of a particualr header
>  file like this one :
> 
>  ✔ ~/git-linux/linux/tools/bootconfig/include/linux [patch L|✔]
> 08:34 $ cat bootconfig.h
> /* SPDX-License-Identifier: GPL-2.0 */
> #ifndef _BOOTCONFIG_LINUX_BOOTCONFIG_H
> #define _BOOTCONFIG_LINUX_BOOTCONFIG_H
> 
> #include "../../../../include/linux/bootconfig.h"
> 
> #endif
> 
> I am surely missing some basic stuff...but...anyway, I have taken a peek on other files in the same dir and none have the nesting like that(the include ../ ...line)
> 
> Any specific reason? OR did you thought of keeping all the header file in one paplace(wildly guessing) ...

If you carefully check the number of ../, you can find that it refers the
 <topdir>/include/linux/bootconfig.h.
Since the bootconfig library code needs bootconfig.h but I don't like to make
a copy of the bootconfig.h under the tools directory, I made a dummy header
file which links to the kernel's bootconfig.h.

Thank you,

-- 
Masami Hiramatsu <mhiramat@...nel.org>