linux-kernel - Re: [PATCH v2 2/2] arm64: dts: qcom: sm8350: Add thermal zones and throttling support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b3f17dd3-d4b3-930c-db02-9f67748e4427@somainline.org>
Date:   Mon, 22 Mar 2021 18:27:13 +0100
From:   Konrad Dybcio <konrad.dybcio@...ainline.org>
To:     Robert Foss <robert.foss@...aro.org>, agross@...nel.org,
        bjorn.andersson@...aro.org, amitk@...nel.org, rui.zhang@...el.com,
        daniel.lezcano@...aro.org, robh+dt@...nel.org,
        linux-arm-msm@...r.kernel.org, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Vinod Koul <vinod.koul@...aro.org>
Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: sm8350: Add thermal zones and
 throttling support

Hi!


> +		tsens0: thermal-sensor@...2000 {
> +			compatible = "qcom,sm8350-tsens", "qcom,tsens-v2";
> +			reg = <0 0x0C263000 0 0x1ff>, /* TM */
> +			      <0 0x0C222000 0 0x8>; /* SROT */

Please use lowercase hex


> +		tsens1: thermal-sensor@...3000 {
> +			compatible = "qcom,sm8350-tsens", "qcom,tsens-v2";
> +			reg = <0 0x0C265000 0 0x1ff>, /* TM */
> +			      <0 0x0c223000 0 0x8>; /* SROT */

Ditto


> +			trips {
> +				cpu0_alert0: trip-point0 {
> +					temperature = <90000>;
> +					hysteresis = <2000>;
> +					type = "passive";
> +				};
> +
> +				cpu0_alert1: trip-point1 {
> +					temperature = <95000>;
> +					hysteresis = <2000>;
> +					type = "passive";

Shouldn't this be "hot"? Possibly ditto for all cpu*alert1-labeled nodes.


> +				};
> +
> +				cpu0_crit: cpu_crit {
> +					temperature = <110000>;
> +					hysteresis = <1000>;
> +					type = "critical";
> +				};
> +			};

These values seem, err.. scorching hot.. Are they alright?



> +		// TODO: What is the NSP subsystem?
Please use C-style comments (/* foo */)

	


Konrad