linux-kernel - Re: [PATCHv4 00/19] perf metric: Add support to reuse metric

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 22 Mar 2021 11:36:23 +0000
From:   John Garry <john.garry@...wei.com>
To:     "Paul A. Clarke" <pc@...ibm.com>, Jiri Olsa <jolsa@...nel.org>
CC:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Michael Petlan <mpetlan@...hat.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Kajol Jain <kjain@...ux.ibm.com>,
        Stephane Eranian <eranian@...gle.com>,
        Ian Rogers <irogers@...gle.com>
Subject: Re: [PATCHv4 00/19] perf metric: Add support to reuse metric

On 01/08/2020 12:40, Paul A. Clarke wrote:
>> v4 changes:
>>    - removed acks from patch because it changed a bit
>>      with the last fixes:
>>        perf metric: Collect referenced metrics in struct metric_ref_node
>>    - fixed runtime metrics [Kajol Jain]
>>    - increased recursion depth [Paul A. Clarke]
>>    - changed patches due to dependencies:
>>        perf metric: Collect referenced metrics in struct metric_ref_node
>>        perf metric: Add recursion check when processing nested metrics
>>        perf metric: Rename struct egroup to metric
>>        perf metric: Rename group_list to metric_list
>>
>> Also available in here:
>>    git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
>>    perf/metric
> I built and ran from the above git branch, and things seem to work.
> Indeed, I was able to apply my changes to exploit the new capabilities
> via modifications to tools/perf/pmu-events/arch/powerpc/power9/metrics.json,
> as I posted earlier (and will submit once this set gets merged).
> 

Hi Paul,

I was just wondering: Does perf subtest 10.3 work ok for you with the 
metric reuse?

That's "Parsing of PMU event table metrics" subtest.

Hi Jirka,

If I add something like this:
     {
         "BriefDescription": "dummy test1",
         "MetricExpr": "Bad_Speculation + Frontend_Bound",
         "MetricGroup": "TopdownL1",
         "MetricName": "dummytest",
         "PublicDescription": "dummy test2"
     },

I get "Parse event failed metric 'dummytest' id 'bad_speculation' expr 
'bad_speculation + frontend_bound'"

Thanks,
john

> Tested-by: Paul A. Clarke<pc@...ibm.com>
> 
> One thing I noted, but which also occurs without these patches, is that
> the perf metrics are not computed unless run as root:
> --
> $ perf stat --metrics br_misprediction_percent command
> 
>   Performance counter stats for 'command':
> 
>       1,823,530,051      pm_br_pred:u
>           2,662,705      pm_br_mpred_cmpl:u
> 
> $ /usr/bin/sudo perf stat --metrics br_misprediction_percent command
> 
>   Performance counter stats for 'command':
> 
>       1,824,655,269      pm_br_pred                #     0.09 br_misprediction_percent
>           1,654,466      pm_br_mpred_cmpl
> --