linux-kernel - Re: [PATCH 1/3] tty: serial: Add UART driver for Cortina-Access platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <E0630C1D-AC64-4DB5-9467-EA2F4590EB26@cortina-access.com>
Date:   Tue, 23 Mar 2021 19:25:58 +0000
From:   Alex Nemirovsky <Alex.Nemirovsky@...tina-access.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Jiri Slaby <jirislaby@...nel.org>,
        Jason Li <jason.li@...tina-access.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>
Subject: Re: [PATCH 1/3] tty: serial: Add UART driver for Cortina-Access
 platform

Hi Greg,

> On Mar 23, 2021, at 2:24 AM, Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:
> 
> On Thu, Feb 18, 2021 at 06:42:09PM -0800, Alex Nemirovsky wrote:
>> +static struct cortina_uart_port *cortina_uart_ports;
> 
> Why is this not a per-device pointer?
> 
>> +static void __exit cortina_uart_exit(void)
>> +{
>> +	platform_driver_unregister(&serial_cortina_driver);
>> +	uart_unregister_driver(&cortina_uart_driver);
>> +	kfree(cortina_uart_ports);
> 
> Should not need to free this here, it should be tied to the device, not
> the driver.

Would it be possible to provide a reference to an example 
of a good way to do it.
> 
> 
>> +}
>> +
>> +module_init(cortina_uart_init);
>> +module_exit(cortina_uart_exit);
>> +
>> +MODULE_AUTHOR("Cortina-Access Inc.");
>> +MODULE_DESCRIPTION(" Cortina-Access UART driver");
>> +MODULE_LICENSE("GPL");
>> diff --git a/include/uapi/linux/serial_core.h b/include/uapi/linux/serial_core.h
>> index 62c2204..1931892 100644
>> --- a/include/uapi/linux/serial_core.h
>> +++ b/include/uapi/linux/serial_core.h
>> @@ -277,4 +277,7 @@
>> /* Freescale LINFlexD UART */
>> #define PORT_LINFLEXUART	122
>> 
>> +/* Cortina-Access UART */
>> +#define PORT_CORTINA_ACCESS	123
> 
> Also, no need for this, right?  I would prefer to not add new ids if at
> all possible.

Could you explain why these are no longer required and what has 
been done in the tty design to make this obsolete?
> 
> thanks,
> 
> greg k-h