linux-kernel - Re: [PATCH] x86/pci: use true and false for bool variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YFpR1PrssmxQl01N@rocinante>
Date:   Tue, 23 Mar 2021 21:38:44 +0100
From:   Krzysztof Wilczyński <kw@...ux.com>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     bhelgaas@...gle.com, tglx@...utronix.de, mingo@...hat.com,
        bp@...en8.de, x86@...nel.org, hpa@...or.com,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/pci: use true and false for bool variable

Hi,

Thank you for sending the patch over!

> fixed the following coccicheck:
> ./arch/x86/pci/mmconfig-shared.c:464:9-10: WARNING: return of 0/1 in
> function 'is_mmconf_reserved' with return type bool
> ./arch/x86/pci/mmconfig-shared.c:493:5-6: WARNING: return of 0/1 in
> function 'is_mmconf_reserved' with return type bool
> ./arch/x86/pci/mmconfig-shared.c:501:9-10: WARNING: return of 0/1 in
> function 'is_mmconf_reserved' with return type bool
> ./arch/x86/pci/mmconfig-shared.c:522:5-6: WARNING: return of 0/1 in
> function 'is_mmconf_reserved' with return type bool
[...]

Looks good, although a few small nitpicks: you should capitalise the
subject line so that it matches the style used in previous commits, and
the commit message could also be improved in terms of style and also
explaining what and why this patch is fixing the return type (aside of
just addressing report from Cocinelle).

Other than that,

Reviewed-by: Krzysztof Wilczyński <kw@...ux.com>

Thank you!

Krzysztof