linux-kernel - Re: [PATCH] X86: __set_clr_pte_enc() miscalculates physical address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 23 Mar 2021 08:20:11 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Tom Lendacky <thomas.lendacky@....com>
Cc:     Isaku Yamahata <isaku.yamahata@...el.com>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        x86@...nel.org, kvm@...r.kernel.org, brijesh.singh@....com,
        tglx@...utronix.de, bp@...en8.de, isaku.yamahata@...il.com,
        "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>
Subject: Re: [PATCH] X86: __set_clr_pte_enc() miscalculates physical address

On Mon, Mar 22, 2021 at 04:02:11PM -0500, Tom Lendacky wrote:
> On 3/18/21 3:26 PM, Isaku Yamahata wrote:
> > __set_clr_pte_enc() miscalculates physical address to operate.
> > pfn is in unit of PG_LEVEL_4K, not PGL_LEVEL_{2M, 1G}.
> > Shift size to get physical address should be PAGE_SHIFT,
> > not page_level_shift().
> > 
> > Fixes: dfaaec9033b8 ("x86: Add support for changing memory encryption attribute in early boot")
> > Reviewed-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>
> > Signed-off-by: Isaku Yamahata <isaku.yamahata@...el.com>
> 
> Reviewed-by: Tom Lendacky <thomas.lendacky@....com>

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>