linux-kernel - Re: [PATCH -next] coresight: etm-perf: Mark format_attr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210323071944.GA55918@leoy-ThinkPad-X240s>
Date:   Tue, 23 Mar 2021 15:19:44 +0800
From:   Leo Yan <leo.yan@...aro.org>
To:     Zou Wei <zou_wei@...wei.com>
Cc:     mathieu.poirier@...aro.org, suzuki.poulose@....com,
        mike.leach@...aro.org, alexander.shishkin@...ux.intel.com,
        coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] coresight: etm-perf: Mark format_attr_contextid
 with static keyword

On Tue, Mar 23, 2021 at 07:54:52AM +0000, Zou Wei wrote:
> Fix the following sparse warning:
> 
> drivers/hwtracing/coresight/coresight-etm-perf.c:61:25: warning: symbol
> 'format_attr_contextid' was not declared. Should it be static?
> 
> Signed-off-by: Zou Wei <zou_wei@...wei.com>

Reviewed-by: Leo Yan <leo.yan@...aro.org>

> ---
>  drivers/hwtracing/coresight/coresight-etm-perf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c
> index 0f603b4094f2..bdbb77334329 100644
> --- a/drivers/hwtracing/coresight/coresight-etm-perf.c
> +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
> @@ -58,7 +58,7 @@ static ssize_t format_attr_contextid_show(struct device *dev,
>  	return sprintf(page, "config:%d\n", pid_fmt);
>  }
>  
> -struct device_attribute format_attr_contextid =
> +static struct device_attribute format_attr_contextid =
>  	__ATTR(contextid, 0444, format_attr_contextid_show, NULL);
>  
>  static struct attribute *etm_config_formats_attr[] = {
> -- 
> 2.17.1
>