linux-kernel - Re: [PATCH v2] drm/omap: dsi: Add missing IRQF_ONESHOT

Open Source and information security mailing list archives

Message-ID: <20210323111539.5wi3ldwfvxvzmio7@earth.universe>
Date:   Tue, 23 Mar 2021 12:15:39 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     tomba@...nel.org, airlied@...ux.ie,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] drm/omap: dsi: Add missing IRQF_ONESHOT

Hi,

On Tue, Mar 23, 2021 at 05:34:53PM +0800, Yang Li wrote:
> fixed the following coccicheck:
> ./drivers/gpu/drm/omapdrm/dss/dsi.c:4329:7-27: ERROR: Threaded IRQ with
> no primary handler requested without IRQF_ONESHOT
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@...labora.com>

Also maybe add this, so that it is properly backported. OTOH old code did
not have IRQF_ONESHOT either.

Fixes: 4c1b935fea54 ("drm/omap: dsi: move TE GPIO handling into core")

-- Sebastian

> Change in v2:
> -Modify the fourth parameter, not the first
> 
>  drivers/gpu/drm/omapdrm/dss/dsi.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c
> index b31d750..5f1722b 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dsi.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c
> @@ -4327,7 +4327,8 @@ static int omap_dsi_register_te_irq(struct dsi_data *dsi,
>  	irq_set_status_flags(te_irq, IRQ_NOAUTOEN);
>  
>  	err = request_threaded_irq(te_irq, NULL, omap_dsi_te_irq_handler,
> -				   IRQF_TRIGGER_RISING, "TE", dsi);
> +				   IRQF_TRIGGER_RISING | IRQF_ONESHOT,
> +				   "TE", dsi);
>  	if (err) {
>  		dev_err(dsi->dev, "request irq failed with %d\n", err);
>  		gpiod_put(dsi->te_gpio);
> -- 
> 1.8.3.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives