[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c0121400eea96626cdd212ad95f296a024356289.camel@linux.intel.com>
Date: Wed, 24 Mar 2021 14:27:54 -0700
From: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
To: Lee Jones <lee.jones@...aro.org>
Cc: linux-kernel@...r.kernel.org,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Anssi Hannula <anssi.hannula@...il.com>,
Benjamin Tissoires <benjamin.tissoires@...hat.com>,
Bruno Prémont <bonbons@...ux-vserver.org>,
Christian König <christian.koenig@....com>,
Daniel Drubin <daniel.drubin@...el.com>,
Dario Pagani <dario.pagani.146+linuxk@...il.com>,
dri-devel@...ts.freedesktop.org,
Henrik Rydberg <rydberg@...math.org>,
Jiri Kosina <jikos@...nel.org>,
Jonathan Cameron <jic23@...nel.org>,
Kai-Heng Feng <kai.heng.feng@...onical.com>,
Kim Kuparinen <kimi.h.kuparinen@...il.com>,
Krzysztof Wilczyński <kw@...ux.com>,
linaro-mm-sig@...ts.linaro.org,
linux-arm-kernel@...ts.infradead.org, linux-iio@...r.kernel.org,
linux-input@...r.kernel.org, linux-media@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
linux-usb@...r.kernel.org, Lopez Casado <nlopezcasad@...itech.com>,
"L. Vinyard, Jr" <rvinyard@...nmsu.edu>,
Masaki Ota <masaki.ota@...alps.com>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
message to <vojtech@....cz>,
Michael Haboustak <mike-@...ci.rr.com>,
Rushikesh S Kadam <rushikesh.s.kadam@...el.com>,
Sumit Semwal <sumit.semwal@...aro.org>,
Uwe Kleine-König <uwe@...ine-koenig.org>,
Vojtech Pavlik <vojtech@...e.cz>,
Zhang Lixu <lixu.zhang@...el.com>
Subject: Re: [PATCH 00/25] Rid W=1 warnings from HID
On Wed, 2021-03-24 at 17:33 +0000, Lee Jones wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
For changes in drivers/hid/intel-ish-hid folder
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
> Lee Jones (25):
> HID: intel-ish-hid: Remove unused variable 'err'
> HID: ishtp-hid-client: Move variable to where it's actually used
> HID: intel-ish-hid: pci-ish: Remove unused variable 'ret'
> HID: intel-ish: Supply some missing param descriptions
> HID: intel-ish: Fix a naming disparity and a formatting error
> HID: usbhid: Repair a formatting issue in a struct description
> HID: intel-ish-hid: Fix a little doc-rot
> HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses
> HID: hid-alps: Correct struct misnaming
> HID: intel-ish-hid: Fix potential copy/paste error
> HID: hid-core: Fix incorrect function name in header
> HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name
> in
> header
> HID: ishtp-hid-client: Fix incorrect function name
> report_bad_packet()
> HID: hid-kye: Fix incorrect function name for kye_tablet_enable()
> HID: hid-picolcd_core: Remove unused variable 'ret'
> HID: hid-logitech-hidpp: Fix conformant kernel-doc header and
> demote
> abuses
> HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs
> HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses
> HID: hid-uclogic-params: Ensure function names are present and
> correct
> in kernel-doc headers
> HID: hid-sensor-custom: Remove unused variable 'ret'
> HID: wacom_sys: Demote kernel-doc abuse
> HID: hid-sensor-hub: Remove unused struct member 'quirks'
> HID: hid-sensor-hub: Move 'hsdev' description to correct struct
> definition
> HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting
> issues
> HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler
> warning
>
> drivers/hid/hid-alps.c | 2 +-
> drivers/hid/hid-core.c | 2 +-
> drivers/hid/hid-kye.c | 2 +-
> drivers/hid/hid-logitech-hidpp.c | 7 +--
> drivers/hid/hid-picolcd_core.c | 5 +--
> drivers/hid/hid-sensor-custom.c | 5 +--
> drivers/hid/hid-sensor-hub.c | 4 +-
> drivers/hid/hid-thrustmaster.c | 24 +++++------
> drivers/hid/hid-uclogic-params.c | 8 ++--
> drivers/hid/hid-uclogic-rdesc.c | 2 +-
> drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +-
> drivers/hid/intel-ish-hid/ipc/pci-ish.c | 3 +-
> drivers/hid/intel-ish-hid/ishtp-fw-loader.c | 45 ++++++++++------
> ----
> drivers/hid/intel-ish-hid/ishtp-hid-client.c | 11 +++--
> drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +-
> drivers/hid/intel-ish-hid/ishtp-hid.h | 9 +---
> drivers/hid/intel-ish-hid/ishtp/bus.c | 9 +++-
> drivers/hid/intel-ish-hid/ishtp/client.c | 5 +--
> drivers/hid/intel-ish-hid/ishtp/hbm.c | 4 +-
> drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h | 4 +-
> drivers/hid/usbhid/hid-pidff.c | 4 +-
> drivers/hid/usbhid/usbkbd.c | 2 +-
> drivers/hid/wacom_sys.c | 2 +-
> include/linux/intel-ish-client-if.h | 8 +++-
> 24 files changed, 90 insertions(+), 81 deletions(-)
>
> Cc: Alexandre Torgue <alexandre.torgue@...s.st.com>
> Cc: Anssi Hannula <anssi.hannula@...il.com>
> Cc: Benjamin Tissoires <benjamin.tissoires@...hat.com>
> Cc: "Bruno Prémont" <bonbons@...ux-vserver.org>
> Cc: "Christian König" <christian.koenig@....com>
> Cc: Daniel Drubin <daniel.drubin@...el.com>
> Cc: Dario Pagani <dario.pagani.146+linuxk@...il.com>
> Cc: dri-devel@...ts.freedesktop.org
> Cc: Henrik Rydberg <rydberg@...math.org>
> Cc: Jiri Kosina <jikos@...nel.org>
> Cc: Jonathan Cameron <jic23@...nel.org>
> Cc: Kai-Heng Feng <kai.heng.feng@...onical.com>
> Cc: Kim Kuparinen <kimi.h.kuparinen@...il.com>
> Cc: "Krzysztof Wilczyński" <kw@...ux.com>
> Cc: Lee Jones <lee.jones@...aro.org>
> Cc: linaro-mm-sig@...ts.linaro.org
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-iio@...r.kernel.org
> Cc: linux-input@...r.kernel.org
> Cc: linux-media@...r.kernel.org
> Cc: linux-stm32@...md-mailman.stormreply.com
> Cc: linux-usb@...r.kernel.org
> Cc: Lopez Casado <nlopezcasad@...itech.com>
> Cc: "L. Vinyard, Jr" <rvinyard@...nmsu.edu>
> Cc: Masaki Ota <masaki.ota@...alps.com>
> Cc: Maxime Coquelin <mcoquelin.stm32@...il.com>
> Cc: message to <vojtech@....cz>
> Cc: Michael Haboustak <mike-@...ci.rr.com>
> Cc: Rushikesh S Kadam <rushikesh.s.kadam@...el.com>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
> Cc: Sumit Semwal <sumit.semwal@...aro.org>
> Cc: "Uwe Kleine-König" <uwe@...ine-koenig.org>
> Cc: Vojtech Pavlik <vojtech@...e.cz>
> Cc: Zhang Lixu <lixu.zhang@...el.com>
Powered by blists - more mailing lists