linux-kernel - Re: [PATCH v3 2/2] gpio: Add Realtek Otto GPIO support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1e3423ddb454c6d6392ce824c794c60a42586ba8.camel@svanheule.net>
Date:   Wed, 24 Mar 2021 22:29:00 +0100
From:   Sander Vanheule <sander@...nheule.net>
To:     devicetree@...r.kernel.org, linux-gpio@...r.kernel.org
Cc:     bert@...t.com, bgolaszewski@...libre.com, linus.walleij@...aro.org,
        linux-kernel@...r.kernel.org, maz@...nel.org, robh+dt@...nel.org,
        tglx@...utronix.de
Subject: Re: [PATCH v3 2/2] gpio: Add Realtek Otto GPIO support

On Wed, 2021-03-24 at 22:22 +0100, Sander Vanheule wrote:
> +static inline u8 read_u8_reg(void __iomem* reg, unsigned int port)
> +{
> +       return ioread8(reg + port);
> +}
> +
> +static inline void write_u8_reg(void __iomem* reg, unsigned int port,
> u8 value)
> +{
> +       iowrite8(value, reg + port);
> +}
> +
> +static inline u16 read_u16_reg(void __iomem* reg, unsigned int port)
> +{
> +       return ioread16(reg + 2 * port);
> +}
> +
> +static inline void write_u16_reg(void __iomem* reg, unsigned int
> port, u16 value)
> +{
> +       iowrite16(value, reg + 2 * port);
> +}

Of course I only noticed this after sending v3, but these functions
should have "void __iomem *reg" instead. I can fix this in a next
version.

Best,
Sander