linux-kernel - Re: [PATCH 1/3] tty: serial: Add UART driver for Cortina-Access platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YFrWXtYKnBCYMnYd@kroah.com>
Date:   Wed, 24 Mar 2021 07:04:14 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Alex Nemirovsky <Alex.Nemirovsky@...tina-access.com>
Cc:     Jiri Slaby <jirislaby@...nel.org>,
        Jason Li <jason.li@...tina-access.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>
Subject: Re: [PATCH 1/3] tty: serial: Add UART driver for Cortina-Access
 platform

On Tue, Mar 23, 2021 at 07:28:51PM +0000, Alex Nemirovsky wrote:
> 
> 
> > On Mar 23, 2021, at 2:22 AM, Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:
> > 
> > On Thu, Feb 18, 2021 at 06:42:09PM -0800, Alex Nemirovsky wrote:
> >> From: Jason Li <jason.li@...tina-access.com>
> >> 
> >> This driver supports Cortina Access UART IP integrated
> >> in most all CAXXXX line of SoCs. Earlycom is also supported
> >> 
> >> Signed-off-by: Jason Li <jason.li@...tina-access.com>
> >> Reviewed-by: Alex Nemirovsky <alex.nemirovsky@...tina-access.com>
> >> ---
> >> MAINTAINERS                                |   5 +
> >> drivers/tty/serial/Kconfig                 |  19 +
> >> drivers/tty/serial/Makefile                |   1 +
> >> drivers/tty/serial/serial_cortina-access.c | 798 +++++++++++++++++++++++++++++
> >> include/uapi/linux/serial_core.h           |   3 +
> >> 5 files changed, 826 insertions(+)
> >> create mode 100644 drivers/tty/serial/serial_cortina-access.c
> >> 
> >> Change log
> >>  drivers/tty/serial/serial_cortina-access.c
> >>   v3:
> >>    - Remove usage of uintptr_t. Change to pointer to driver's private
> >>      structure instead.
> > 
> > Is this really a "v3"?  The subject lines do not show that, so I'm
> > totally confused as to what to review and what has been reviewed here.
> > 
> > Please fix this up and submit a "v4" so we know what is going on :)
> 
> Could you recommend a method or a tool to update the commit subject id with a version prefix?
> Currently we are doing a git format-patch and the subject line is automatically created without a 
> version number. Do you just go in manual and edit the resulting patch contents file or do you use a 
> tool to assist in this?

This is only 3 patches, they are easy to edit by hand...  :)

Anyway 'git format-patch' can do this automatically for you if you want,
see the -v or --reroll-count option.

thanks,

greg k-h