linux-kernel - Re: [PATCH 7/9] watchdog: of_xilinx_wdt: Add Versal Window watchdog support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2241024e-3791-4733-4d4a-a4ea12582e92@roeck-us.net>
Date:   Wed, 24 Mar 2021 07:01:33 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Srinivas Neeli <sneeli@...inx.com>,
        Michal Simek <michals@...inx.com>,
        Shubhrajyoti Datta <shubhraj@...inx.com>,
        Srinivas Goud <sgoud@...inx.com>
Cc:     "wim@...ux-watchdog.org" <wim@...ux-watchdog.org>,
        "linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        git <git@...inx.com>
Subject: Re: [PATCH 7/9] watchdog: of_xilinx_wdt: Add Versal Window watchdog
 support

On 3/23/21 11:04 PM, Srinivas Neeli wrote:
> Hi Guenter,
> 
> Thanks for review
> 
>> -----Original Message-----
>> From: Guenter Roeck <groeck7@...il.com> On Behalf Of Guenter Roeck
>> Sent: Tuesday, March 16, 2021 8:01 AM
>> To: Srinivas Neeli <sneeli@...inx.com>; Michal Simek <michals@...inx.com>;
>> Shubhrajyoti Datta <shubhraj@...inx.com>; Srinivas Goud
>> <sgoud@...inx.com>
>> Cc: wim@...ux-watchdog.org; linux-watchdog@...r.kernel.org; linux-arm-
>> kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; git
>> <git@...inx.com>
>> Subject: Re: [PATCH 7/9] watchdog: of_xilinx_wdt: Add Versal Window
>> watchdog support
>>
>> On 3/15/21 3:46 AM, Srinivas Neeli wrote:
>>> Versal watchdog driver uses Window watchdog mode. Window watchdog
>>> timer(WWDT) contains closed(first) and open(second) window with
>>> 32 bit width. WWDT will generate an interrupt after the first window
>>> timeout and reset signal after the second window timeout. Timeout and
>>> Pre-timeout configuration, Stop and Refresh trigger only in open
>>> window.
>>>
>>> Signed-off-by: Srinivas Neeli <srinivas.neeli@...inx.com>
>>
>> I think this should be a separate watchdog driver. There is pretty much no
>> overlap with the existing driver.
> 
> Xilinx AXI Timebase Watchdog Timer supports two independent modes
> 1)Timebase Watchdog Mode
> 2)Window Watchdog Timer Mode.
> Current of_xilinx_wdt.c driver already have support for Timebase Watchdog Mode, but Window watchdog timer Mode feature is missing.
> Versal platform contains customized AXI Timebase Watchdog Timer, which supports Window Watchdog Timer Mode.
> For that reason we are creating common driver for both the modes.
> 

That is not an argument. The two watchdogs are still completely different,
and there is no value having a single driver.

Guenter