linux-kernel - Re: [PATCH 4/4] dt-bindings: usb: Add chg-psy-name property Maxim 33359 binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210324145042.GA3036037@robh.at.kernel.org>
Date:   Wed, 24 Mar 2021 08:50:42 -0600
From:   Rob Herring <robh@...nel.org>
To:     Badhri Jagan Sridharan <badhri@...gle.com>
Cc:     Guenter Roeck <linux@...ck-us.net>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Kyle Tso <kyletso@...gle.com>, devicetree@...r.kernel.org
Subject: Re: [PATCH 4/4] dt-bindings: usb: Add chg-psy-name property Maxim
 33359 binding

On Thu, Mar 11, 2021 at 02:03:13AM -0800, Badhri Jagan Sridharan wrote:
> chg-psy-name is an optional string property used to indicate the
> power supply object for which the current/voltage_max limits have
> to be set.
> 
> Signed-off-by: Badhri Jagan Sridharan <badhri@...gle.com>
> ---
>  Documentation/devicetree/bindings/usb/maxim,max33359.yaml | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml
> index 93a19eda610b..3a278969109e 100644
> --- a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml
> +++ b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml
> @@ -28,6 +28,11 @@ properties:
>      description:
>        Properties for usb c connector.
>  
> +  chg-psy-name:
> +    description: Power supply whose current/voltage_max values to be
> +      configured.
> +    $ref: /schemas/types.yaml#definitions/string

If you want a non-vendor specific property, this needs to be documented 
in a common binding. I think this needs a better explaination and 
examples of multiple chargers.

Rob