linux-kernel - Re: [PATCH] i2c: designware: Add base addr info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YFyvh3sqyVcg8Iqj@smile.fi.intel.com>
Date:   Thu, 25 Mar 2021 17:43:03 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Daniel Gomez <daniel@...c.com>
Cc:     Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: designware: Add base addr info

On Thu, Mar 25, 2021 at 04:12:48PM +0100, Daniel Gomez wrote:
> Add i2c hw base address in the adapter name and when the device is
> probed.

Why?
We have /proc/iomem for that.

Sorry, I don't see value of this change.
Some comments  below just to let you know about style:ish issues.

...

>  	snprintf(adap->name, sizeof(adap->name),
> -		 "Synopsys DesignWare I2C adapter");
> +		 "Synopsys DesignWare I2C adapter at 0x%llx", dev->base_addr);

It actually should be resource_size_t and corresponding specifier, i.e. %pa to
print it. Moreover, we have %pR (and %pr) specifiers for struct resource.

...

> +	dev_info(&pdev->dev, "%s\n", adap->name);

Unneeded noise.

-- 
With Best Regards,
Andy Shevchenko