linux-kernel - Re: [PATCH] i2c: designware: Add base addr info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202103260951.s6OtTemN-lkp@intel.com>
Date:   Fri, 26 Mar 2021 09:50:48 +0800
From:   kernel test robot <lkp@...el.com>
To:     Daniel Gomez <daniel@...c.com>
Cc:     kbuild-all@...ts.01.org, Daniel Gomez <daniel@...c.com>,
        Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: designware: Add base addr info

Hi Daniel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on wsa/i2c/for-next]
[also build test WARNING on v5.12-rc4 next-20210325]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Daniel-Gomez/i2c-designware-Add-base-addr-info/20210325-232218
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next
config: i386-randconfig-r016-20210325 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/5233e225fc69cfeef637d28c49f12967cbc36430
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Daniel-Gomez/i2c-designware-Add-base-addr-info/20210325-232218
        git checkout 5233e225fc69cfeef637d28c49f12967cbc36430
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/i2c/busses/i2c-designware-master.c: In function 'i2c_dw_probe_master':
>> drivers/i2c/busses/i2c-designware-master.c:770:45: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 4 has type 'phys_addr_t' {aka 'unsigned int'} [-Wformat=]
     770 |    "Synopsys DesignWare I2C adapter at 0x%llx", dev->base_addr);
         |                                          ~~~^   ~~~~~~~~~~~~~~
         |                                             |      |
         |                                             |      phys_addr_t {aka unsigned int}
         |                                             long long unsigned int
         |                                          %x


vim +770 drivers/i2c/busses/i2c-designware-master.c

   740	
   741	int i2c_dw_probe_master(struct dw_i2c_dev *dev)
   742	{
   743		struct i2c_adapter *adap = &dev->adapter;
   744		unsigned long irq_flags;
   745		int ret;
   746	
   747		init_completion(&dev->cmd_complete);
   748	
   749		dev->init = i2c_dw_init_master;
   750		dev->disable = i2c_dw_disable;
   751		dev->disable_int = i2c_dw_disable_int;
   752	
   753		ret = i2c_dw_init_regmap(dev);
   754		if (ret)
   755			return ret;
   756	
   757		ret = i2c_dw_set_timings_master(dev);
   758		if (ret)
   759			return ret;
   760	
   761		ret = i2c_dw_set_fifo_size(dev);
   762		if (ret)
   763			return ret;
   764	
   765		ret = dev->init(dev);
   766		if (ret)
   767			return ret;
   768	
   769		snprintf(adap->name, sizeof(adap->name),
 > 770			 "Synopsys DesignWare I2C adapter at 0x%llx", dev->base_addr);
   771		adap->retries = 3;
   772		adap->algo = &i2c_dw_algo;
   773		adap->quirks = &i2c_dw_quirks;
   774		adap->dev.parent = dev->dev;
   775		i2c_set_adapdata(adap, dev);
   776	
   777		if (dev->flags & ACCESS_NO_IRQ_SUSPEND) {
   778			irq_flags = IRQF_NO_SUSPEND;
   779		} else {
   780			irq_flags = IRQF_SHARED | IRQF_COND_SUSPEND;
   781		}
   782	
   783		i2c_dw_disable_int(dev);
   784		ret = devm_request_irq(dev->dev, dev->irq, i2c_dw_isr, irq_flags,
   785				       dev_name(dev->dev), dev);
   786		if (ret) {
   787			dev_err(dev->dev, "failure requesting irq %i: %d\n",
   788				dev->irq, ret);
   789			return ret;
   790		}
   791	
   792		ret = i2c_dw_init_recovery_info(dev);
   793		if (ret)
   794			return ret;
   795	
   796		/*
   797		 * Increment PM usage count during adapter registration in order to
   798		 * avoid possible spurious runtime suspend when adapter device is
   799		 * registered to the device core and immediate resume in case bus has
   800		 * registered I2C slaves that do I2C transfers in their probe.
   801		 */
   802		pm_runtime_get_noresume(dev->dev);
   803		ret = i2c_add_numbered_adapter(adap);
   804		if (ret)
   805			dev_err(dev->dev, "failure adding adapter: %d\n", ret);
   806		pm_runtime_put_noidle(dev->dev);
   807	
   808		return ret;
   809	}
   810	EXPORT_SYMBOL_GPL(i2c_dw_probe_master);
   811	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (34920 bytes)