linux-kernel - Re: [PATCH] drivers: staging:

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210325073154.GU1717@kadam>
Date:   Thu, 25 Mar 2021 10:31:54 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Wan Jiabing <wanjiabing@...o.com>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        kael_w@...h.net
Subject: Re: [PATCH] drivers: staging: _adapter is declared twice

On Thu, Mar 25, 2021 at 02:28:40PM +0800, Wan Jiabing wrote:
> struct _adapter has been declared at 23rd line. 
> Remove the duplicate.
> 
> Signed-off-by: Wan Jiabing <wanjiabing@...o.com>
> ---
>  drivers/staging/rtl8712/drv_types.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8712/drv_types.h b/drivers/staging/rtl8712/drv_types.h
> index 0c4325073c63..976d19cdcf87 100644
> --- a/drivers/staging/rtl8712/drv_types.h
> +++ b/drivers/staging/rtl8712/drv_types.h
> @@ -36,7 +36,6 @@ enum _NIC_VERSION {
>  	RTL8716_NIC
>  };
>  
> -struct _adapter;
>  
>  struct	qos_priv	{

You need to delete the blank line after it as well to avoid the
checkpatch warning about two blank lines in a row.

regards,
dan carpenter