linux-kernel - Re: [PATCH v2] infiniband: Fix a use after free in isert_connect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <413a083c-83b3-fcc8-f5e2-d9721874fad5@nvidia.com>
Date:   Thu, 25 Mar 2021 12:56:12 +0200
From:   Max Gurtovoy <mgurtovoy@...dia.com>
To:     Lv Yunlong <lyl2019@...l.ustc.edu.cn>, <sagi@...mberg.me>,
        <dledford@...hat.com>, <jgg@...pe.ca>
CC:     <linux-rdma@...r.kernel.org>, <target-devel@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] infiniband: Fix a use after free in
 isert_connect_request


On 3/22/2021 6:13 PM, Lv Yunlong wrote:
> The device is got by isert_device_get() with refcount is 1,
> and is assigned to isert_conn by isert_conn->device = device.
> When isert_create_qp() failed, device will be freed with
> isert_device_put().
>
> Later, the device is used in isert_free_login_buf(isert_conn)
> by the isert_conn->device->ib_device statement. This patch
> free the device in the correct order.
>
> Signed-off-by: Lv Yunlong <lyl2019@...l.ustc.edu.cn>
> ---
>   drivers/infiniband/ulp/isert/ib_isert.c | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)

looks good,

Reviewed-by: Max Gurtovoy <mgurtovoy@...dia.com>