linux-kernel - Re: [PATCH] ALSA: usb-audio: Apply sample rate quirk to Logitech Connect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 25 Mar 2021 11:01:08 +0000
From:   Joakim Tjernlund <Joakim.Tjernlund@...inera.com>
To:     "ikjn@...omium.org" <ikjn@...omium.org>,
        "tiwai@...e.de" <tiwai@...e.de>
CC:     "grpintar@...il.com" <grpintar@...il.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "dylan_robinson@...u.com" <dylan_robinson@...u.com>,
        "kai.heng.feng@...onical.com" <kai.heng.feng@...onical.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "tiwai@...e.com" <tiwai@...e.com>, "livvy@...e.nu" <livvy@...e.nu>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "alexander@...y.me" <alexander@...y.me>,
        "perex@...ex.cz" <perex@...ex.cz>
Subject: Re: [PATCH] ALSA: usb-audio: Apply sample rate quirk to Logitech
 Connect

On Wed, 2021-03-24 at 13:49 +0100, Takashi Iwai wrote:
> On Wed, 24 Mar 2021 13:03:14 +0100,
> Ikjoon Jang wrote:
> > 
> > On Wed, Mar 24, 2021, 7:16 PM Joakim Tjernlund <Joakim.Tjernlund@...inera.com>
> > wrote:
> > 
> 
> The Logitech devices with 046d:* should be covered generally in
> snd_usb_ctl_msg_quirk(), so I guess it's a different problem.
> But please check it first.
> 
> > And 20ms can be too long if it's applied to every control transfer. I will
> > test the device with shorter delay if you didn't try it before.
> 
> Actually the delay applied to Logitech devices is from 1 to 2ms, not
> 20ms.  The 20ms delay is applied for some other devices.  But if
> extending the delay fixes the problem, we need to reconsider the delay
> length.
> 

There are a lot of devices USB Audio devices that need that 1-2 ms delay. Have
you considered to make this delay generic(for all Audio USB devices) ?
Seems like Windows has something similar as these devices just work there.

 Jocke