linux-kernel - Re: [PATCH] kernel/sched: remove duplicate include in sched.h sched.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 24 Mar 2021 21:34:16 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     menglong8.dong@...il.com
Cc:     mingo@...hat.com, peterz@...radead.org, juri.lelli@...hat.com,
        vincent.guittot@...aro.org, dietmar.eggemann@....com,
        bsegall@...gle.com, mgorman@...e.de, bristot@...hat.com,
        linux-kernel@...r.kernel.org,
        Xiong Zhenwu <xiong.zhenwu@....com.cn>
Subject: Re: [PATCH] kernel/sched: remove duplicate include in sched.h
 sched.h

On Thu,  4 Mar 2021 04:09:26 -0800
menglong8.dong@...il.com wrote:

> From: Xiong Zhenwu <xiong.zhenwu@....com.cn>
> 
> 'linux/psi.h' included in 'kernel/sched/sched.h' is duplicated. it also
> include in 59th line.
> 

Yep, #include <linux/psi.h> is at the top of the file, no need to have
it again in the the CGROUP_SCHED conditional.

Reviewed-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

-- Steve


> Signed-off-by: Xiong Zhenwu <xiong.zhenwu@....com.cn>
> ---
>  kernel/sched/sched.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index 10a1522b1e30..235d8381f142 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -344,7 +344,6 @@ extern bool dl_cpu_busy(unsigned int cpu);
>  #ifdef CONFIG_CGROUP_SCHED
>  
>  #include <linux/cgroup.h>
> -#include <linux/psi.h>
>  
>  struct cfs_rq;
>  struct rt_rq;