linux-kernel - Re: [PATCH] tools: usbip: list.h: fix kernel-doc for list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0064f460-de49-98c8-1448-3489aa036384@infradead.org>
Date:   Wed, 24 Mar 2021 18:35:01 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Shuah Khan <skhan@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Cc:     Valentina Manea <valentina.manea.m@...il.com>,
        Shuah Khan <shuah@...nel.org>, linux-usb@...r.kernel.org
Subject: Re: [PATCH] tools: usbip: list.h: fix kernel-doc for list_del()

On 3/24/21 4:32 PM, Shuah Khan wrote:
> On 3/23/21 6:02 PM, Randy Dunlap wrote:
>> In list.h, the kernel-doc for list_del() should be immediately
>> preceding the implementation and not separated from it by
>> another function implementation.
>>
>> Eliminates this kernel-doc error:
>> list.h:1: warning: 'list_del' not found
>>
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>> Cc: Valentina Manea <valentina.manea.m@...il.com>
>> Cc: Shuah Khan <shuah@...nel.org>
>> Cc: Shuah Khan <skhan@...uxfoundation.org>
>> Cc: linux-usb@...r.kernel.org
>> ---
>>   tools/usb/usbip/libsrc/list.h |   10 +++++-----
>>   1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> --- linux-next-20210323.orig/tools/usb/usbip/libsrc/list.h
>> +++ linux-next-20210323/tools/usb/usbip/libsrc/list.h
>> @@ -77,17 +77,17 @@ static inline void __list_del(struct lis
>>   #define LIST_POISON1  ((void *) 0x00100100 + POISON_POINTER_DELTA)
>>   #define LIST_POISON2  ((void *) 0x00200200 + POISON_POINTER_DELTA)
>>   +static inline void __list_del_entry(struct list_head *entry)
>> +{
>> +    __list_del(entry->prev, entry->next);
>> +}
>> +
>>   /**
>>    * list_del - deletes entry from list.
>>    * @entry: the element to delete from the list.
>>    * Note: list_empty() on entry does not return true after this, the entry is
>>    * in an undefined state.
>>    */
>> -static inline void __list_del_entry(struct list_head *entry)
>> -{
>> -    __list_del(entry->prev, entry->next);
>> -}
>> -
>>   static inline void list_del(struct list_head *entry)
>>   {
>>       __list_del(entry->prev, entry->next);
>>
> 
> Thank you for fixing this.
> 
> Acked-by: Shuah Khan <skhan@...uxfoundation.org>


Thanks. Who do you think should merge this patch?

-- 
~Randy