linux-kernel - Re: [PATCH] include: linux: debug_locks: Remove duplicate declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YFyOjtTI8XXPKgph@smile.fi.intel.com>
Date:   Thu, 25 Mar 2021 15:22:22 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Wan Jiabing <wanjiabing@...o.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Petr Mladek <pmladek@...e.com>,
        Peter Zijlstra <peterz@...radead.org>,
        linux-kernel@...r.kernel.org, kael_w@...h.net
Subject: Re: [PATCH] include: linux: debug_locks: Remove duplicate declaration

On Thu, Mar 25, 2021 at 10:26:58AM +0800, Wan Jiabing wrote:
> struct task_struct is declared at 9th line. Remove the duplicate.

It seems the duplicate is the other one and you removed wrong one.

> Signed-off-by: Wan Jiabing <wanjiabing@...o.com>
> ---
>  include/linux/debug_locks.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/linux/debug_locks.h b/include/linux/debug_locks.h
> index 2915f56ad421..0b3187a5290d 100644
> --- a/include/linux/debug_locks.h
> +++ b/include/linux/debug_locks.h
> @@ -46,7 +46,6 @@ extern int debug_locks_off(void);
>  # define locking_selftest()	do { } while (0)
>  #endif
>  
> -struct task_struct;
>  
>  #ifdef CONFIG_LOCKDEP
>  extern void debug_show_all_locks(void);
> -- 
> 2.25.1
> 

-- 
With Best Regards,
Andy Shevchenko