linux-kernel - Re: [PATCH] PCI: endpoint: remove redundant initialization of pointer dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 Mar 2021 23:15:14 +0100
From:   Krzysztof Wilczyński <kw@...ux.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: endpoint: remove redundant initialization of
 pointer dev

Hi Colin,

> The pointer dev is being initialized with a value that is
> never read and it is being updated later with a new value.  The
> initialization is redundant and can be removed.
[...]
> -	struct device *dev = epf->epc->dev.parent;
> +	struct device *dev;
>  	struct pci_epf_bar *epf_bar;
>  	struct pci_epc *epc;

Thank you!

Reviewed-by: Krzysztof Wilczyński <kw@...ux.com>

Krzysztof