linux-kernel - Re: [PATCH] selftests: powerpc: unmark non-kernel-doc comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a6qq8qni.fsf@linkitivity.dja.id.au>
Date:   Fri, 26 Mar 2021 15:50:25 +1100
From:   Daniel Axtens <dja@...ens.net>
To:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc:     Randy Dunlap <rdunlap@...radead.org>, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH] selftests: powerpc: unmark non-kernel-doc comments

Randy Dunlap <rdunlap@...radead.org> writes:

> Drop the 'beginning of kernel-doc' notation markers (/**)
> in places that are not in kernel-doc format.

This looks good to me. Arguably we don't need the comments at all, but
it doesn't seem to hurt to keep them.

checkpatch is OK with the entire file, so there's nothing else we'd
really want to clean up while you're doing cleanups.

Reviewed-by: Daniel Axtens <dja@...ens.net>

Kind regards,
Daniel

>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Michael Ellerman <mpe@...erman.id.au>
> Cc: linuxppc-dev@...ts.ozlabs.org
> ---
>  tools/testing/selftests/powerpc/tm/tm-trap.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-next-20210323.orig/tools/testing/selftests/powerpc/tm/tm-trap.c
> +++ linux-next-20210323/tools/testing/selftests/powerpc/tm/tm-trap.c
> @@ -66,7 +66,7 @@ void trap_signal_handler(int signo, sigi
>  	/* Get thread endianness: extract bit LE from MSR */
>  	thread_endianness = MSR_LE & ucp->uc_mcontext.gp_regs[PT_MSR];
>  
> -	/***
> +	/*
>  	 * Little-Endian Machine
>  	 */
>  
> @@ -126,7 +126,7 @@ void trap_signal_handler(int signo, sigi
>  		}
>  	}
>  
> -	/***
> +	/*
>  	 * Big-Endian Machine
>  	 */
>