linux-kernel - Re: [PATCH v2] lib: fix kconfig dependency on ARCH_WANT_FRAME

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87lfa7ved3.fsf@linux-m68k.org>
Date:   Sun, 28 Mar 2021 11:04:08 +0200
From:   Andreas Schwab <schwab@...ux-m68k.org>
To:     Julian Braha <julianbraha@...il.com>
Cc:     akpm@...ux-foundation.org, geert@...ux-m68k.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] lib: fix kconfig dependency on ARCH_WANT_FRAME_POINTERS

On Mär 28 2021, Julian Braha wrote:

> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 2779c29d9981..8d53ed423899 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1665,7 +1665,7 @@ config LATENCYTOP
>  	depends on DEBUG_KERNEL
>  	depends on STACKTRACE_SUPPORT
>  	depends on PROC_FS
> -	select FRAME_POINTER if !MIPS && !PPC && !S390 && !MICROBLAZE && !ARM && !ARC && !X86
> +	select FRAME_POINTER if MIPS || PPC || S390 || MICROBLAZE || ARM || ARC || X86

That doesn't look correct.  It reverses the condition without reversing
the result, which means the result is probably the opposite than intended.

The same expression occurs two more times in this file.  Do those need
to be changed as well?

Andreas.

-- 
Andreas Schwab, schwab@...ux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."