linux-kernel - Re: [PATCH v2] lib: fix kconfig dependency on ARCH_WANT_FRAME

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4773905.PvQZvdar3e@ubuntu-mate-laptop>
Date:   Mon, 29 Mar 2021 12:32:52 -0400
From:   Julian Braha <julianbraha@...il.com>
To:     Andreas Schwab <schwab@...ux-m68k.org>
Cc:     geert@...ux-m68k.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] lib: fix kconfig dependency on ARCH_WANT_FRAME_POINTERS

On Sunday, March 28, 2021 5:04:08 AM EDT you wrote:
> On Mär 28 2021, Julian Braha wrote:
> 
> > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> > index 2779c29d9981..8d53ed423899 100644
> > --- a/lib/Kconfig.debug
> > +++ b/lib/Kconfig.debug
> > @@ -1665,7 +1665,7 @@ config LATENCYTOP
> >  	depends on DEBUG_KERNEL
> >  	depends on STACKTRACE_SUPPORT
> >  	depends on PROC_FS
> > -	select FRAME_POINTER if !MIPS && !PPC && !S390 && !MICROBLAZE && !ARM && !ARC && !X86
> > +	select FRAME_POINTER if MIPS || PPC || S390 || MICROBLAZE || ARM || ARC || X86
> 
> That doesn't look correct.  It reverses the condition without reversing
> the result, which means the result is probably the opposite than intended.
> 
> The same expression occurs two more times in this file.  Do those need
> to be changed as well?
> 
> Andreas.
> 
> 

Hi all,

This was a mistake - I'll resubmit the proper patch. 
Also: yes, the other usages of this select expression in this file
will cause more unmet dependency bugs. 
I'll include those in the resubmission as well.

- Julian Braha