linux-kernel - Re: [PATCH v3 03/18] ovl: stack fileattr ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJfpegun3LHMZ9uVxbf5knZB6w1CnUHHXeYpn_ReCTdXKaFX0w@mail.gmail.com>
Date:   Mon, 29 Mar 2021 11:24:30 +0200
From:   Miklos Szeredi <miklos@...redi.hu>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     Miklos Szeredi <mszeredi@...hat.com>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 03/18] ovl: stack fileattr ops

On Sun, Mar 28, 2021 at 8:09 PM Al Viro <viro@...iv.linux.org.uk> wrote:
>
> On Thu, Mar 25, 2021 at 08:37:40PM +0100, Miklos Szeredi wrote:
> > Add stacking for the fileattr operations.
> >
> > Add hack for calling security_file_ioctl() for now.  Probably better to
> > have a pair of specific hooks for these operations.
>
> Umm...  Shouldn't you remove the old code from their ->ioctl() instance?

Will do, once fuse gets converted.

And fuse will get converted, when I manage to decide on the best way to do it:

1) keep a list of open files for each inode, pick random one for doing
the ioctl (really shouldn't matter which one)

2) do a sequence of open - [sg]et attr - release for each invocation

Thanks,
Miklos