linux-kernel - Re: [PATCH v3 01/18] vfs: add fileattr ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Apr 2021 15:45:02 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Miklos Szeredi <mszeredi@...hat.com>
Cc:     linux-fsdevel@...r.kernel.org, Al Viro <viro@...iv.linux.org.uk>,
        "Darrick J . Wong" <djwong@...nel.org>,
        Amir Goldstein <amir73il@...il.com>,
        David Sterba <dsterba@...e.cz>,
        Christian Brauner <christian.brauner@...ntu.com>,
        Eric Biggers <ebiggers@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 01/18] vfs: add fileattr ops

On Thu, Mar 25, 2021 at 08:37:38PM +0100, Miklos Szeredi wrote:
> @@ -107,6 +110,8 @@ fiemap:		no
>  update_time:	no
>  atomic_open:	shared (exclusive if O_CREAT is set in open flags)
>  tmpfile:	no
> +fileattr_get:	no or exclusive
> +fileattr_set:	exclusive
>  ============	=============================================

This introduces a warning to `make htmldocs`:

/home/willy/kernel/folio/Documentation/filesystems/locking.rst:113: WARNING: Malformed table.
Text in column margin in table line 24.

You need to add an extra '=' to the first batch of '=' (on all three lines of
the table).  Like this:

@@ -87,9 +87,9 @@ prototypes::
 locking rules:
        all may block
 
-============   =============================================
+=============  =============================================
 ops            i_rwsem(inode)
-============   =============================================
+=============  =============================================
 lookup:                shared
 create:                exclusive
 link:          exclusive (both)
@@ -112,7 +112,7 @@ atomic_open:        shared (exclusive if O_CREAT is set in open flags)
 tmpfile:       no
 fileattr_get:  no or exclusive
 fileattr_set:  exclusive
-============   =============================================
+=============  =============================================

(whitespace damaged)