linux-kernel - Re: [PATCH v3 01/18] vfs: add fileattr ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJfpeguoKOpfCy1cJhKu1gWk53c=Od5Siyag=reT=KC1kqEuxQ@mail.gmail.com>
Date:   Tue, 13 Apr 2021 16:53:01 +0200
From:   Miklos Szeredi <miklos@...redi.hu>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     Miklos Szeredi <mszeredi@...hat.com>,
        linux-fsdevel@...r.kernel.org, Al Viro <viro@...iv.linux.org.uk>,
        "Darrick J . Wong" <djwong@...nel.org>,
        Amir Goldstein <amir73il@...il.com>,
        David Sterba <dsterba@...e.cz>,
        Christian Brauner <christian.brauner@...ntu.com>,
        Eric Biggers <ebiggers@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 01/18] vfs: add fileattr ops

On Tue, Apr 13, 2021 at 4:46 PM Matthew Wilcox <willy@...radead.org> wrote:
>
> On Thu, Mar 25, 2021 at 08:37:38PM +0100, Miklos Szeredi wrote:
> > @@ -107,6 +110,8 @@ fiemap:           no
> >  update_time: no
> >  atomic_open: shared (exclusive if O_CREAT is set in open flags)
> >  tmpfile:     no
> > +fileattr_get:        no or exclusive
> > +fileattr_set:        exclusive
> >  ============ =============================================
>
> This introduces a warning to `make htmldocs`:
>
> /home/willy/kernel/folio/Documentation/filesystems/locking.rst:113: WARNING: Malformed table.
> Text in column margin in table line 24.
>
> You need to add an extra '=' to the first batch of '=' (on all three lines of
> the table).  Like this:

Yep, already fixed in #fileattr_v6, which I asked Al to pull.

Thanks,
Miklos