linux-kernel - Re: [PATCH 23/25] HID: hid-sensor-hub: Move 'hsdev' description to correct struct definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 29 Mar 2021 16:22:51 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     linux-kernel@...r.kernel.org, Jiri Kosina <jikos@...nel.org>,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-input@...r.kernel.org, linux-iio@...r.kernel.org
Subject: Re: [PATCH 23/25] HID: hid-sensor-hub: Move 'hsdev' description to
 correct struct definition

On Mon, 29 Mar 2021 14:00:07 +0100
Lee Jones <lee.jones@...aro.org> wrote:

> On Mon, 29 Mar 2021, Jonathan Cameron wrote:
> 
> > On Fri, 26 Mar 2021 14:34:56 +0000
> > Lee Jones <lee.jones@...aro.org> wrote:
> >   
> > > Fixes the following W=1 kernel build warning(s):
> > > 
> > >  drivers/hid/hid-sensor-hub.c:54: warning: Function parameter or member 'hsdev' not described in 'hid_sensor_hub_callbacks_list'
> > >   
> > 
> > Perhaps nice to mention that this was a result of
> > 
> > ca2ed12f163b ("HID: hid-sensor-hub: Processing for duplicate physical ids")  
> 
> I only tend to do that for Fixes: tags, but Greg has made it clear
> that these patches are not suitable for stable.

Ok, I was deliberately not including Fixes for that reason, but
I guess some other script might moan if we do that :)

> 
> > > Cc: Jiri Kosina <jikos@...nel.org>
> > > Cc: Jonathan Cameron <jic23@...nel.org>
> > > Cc: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
> > > Cc: Benjamin Tissoires <benjamin.tissoires@...hat.com>
> > > Cc: linux-input@...r.kernel.org
> > > Cc: linux-iio@...r.kernel.org
> > > Signed-off-by: Lee Jones <lee.jones@...aro.org>  
> 
> > Acked-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>  
> 
> Thanks dude, much appreciated.
>