linux-kernel - Re: [PATCH 1/1] of: unittest: rename overlay source files from .dts to .dtso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3e6710e7-08ac-7d1b-aa69-bcd36f0d932a@gmail.com>
Date:   Mon, 29 Mar 2021 14:23:00 -0500
From:   Frank Rowand <frowand.list@...il.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Viresh Kumar <viresh.kumar@...aro.org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        David Gibson <david@...son.dropbear.id.au>,
        Michal Simek <michal.simek@...inx.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        anmar.oueja@...aro.org, Bill Mills <bill.mills@...aro.org>,
        devicetree@...r.kernel.org,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] of: unittest: rename overlay source files from .dts
 to .dtso

On 3/27/21 12:40 PM, Rob Herring wrote:
> On Wed, Mar 24, 2021 at 05:37:13PM -0500, frowand.list@...il.com wrote:
>> From: Frank Rowand <frank.rowand@...y.com>
>>
>> Add Makefile rule to build .dtbo.o assembly file from overlay .dtso
>> source file.
>>
>> Rename unittest .dts overlay source files to use .dtso suffix.
> 
> I'm pretty lukewarm on .dtso...

I was originally also, but I'm warming up to it.

> 
>>
>> Update Makefile to build .dtbo.o objects instead of .dtb.o from
>> unittest overlay source files.
>>
>> Modify unitest.c to use .dtbo.o based symbols instead of .dtb.o
>>
>> Modify Makefile.lib %.dtbo rule to depend upon %.dtso instead of %.dts
>>
>> Documentation/devicetree/of_unittest.rst was already out of date.
>> This commit would make it even more out of date.  Delete the document
>> instead of continuing the maintenance burden of keeping the document
>> in sync with the source.
> 
> This should be a separate change. It's also going to collide with my doc 
> improvements.

I'll split it out.

> 
> Improvements here would be better than just deleting.

OK, I'll make the document more abstract so that code
changes will be less likely to require document changes.

-Frank