linux-kernel - Re: [PATCH -tip] locking: Move CONFIG_LOCK_EVENT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9c703d99-c08c-ad9d-e60d-d786737cfd6f@redhat.com>
Date:   Mon, 29 Mar 2021 22:13:14 -0400
From:   Waiman Long <longman@...hat.com>
To:     Davidlohr Bueso <dave@...olabs.net>, peterz@...radead.org,
        mingo@...hat.com
Cc:     will@...nel.org, linux-kernel@...r.kernel.org,
        Davidlohr Bueso <dbueso@...e.de>
Subject: Re: [PATCH -tip] locking: Move CONFIG_LOCK_EVENT_COUNTS into Kernel
 hacking section

On 3/29/21 10:06 PM, Davidlohr Bueso wrote:
> It's a lot more intuitive to have it in the locking section of the kernel
> hacking part rather than under "General architecture-dependent options".
>
> Signed-off-by: Davidlohr Bueso <dbueso@...e.de>
> ---
>   arch/Kconfig      | 9 ---------
>   lib/Kconfig.debug | 9 +++++++++
>   2 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/arch/Kconfig b/arch/Kconfig
> index ecfd3520b676..d6f9aeaaf9f2 100644
> --- a/arch/Kconfig
> +++ b/arch/Kconfig
> @@ -1113,15 +1113,6 @@ config HAVE_ARCH_PREL32_RELOCATIONS
>   config ARCH_USE_MEMREMAP_PROT
>   	bool
>   
> -config LOCK_EVENT_COUNTS
> -	bool "Locking event counts collection"
> -	depends on DEBUG_FS
> -	help
> -	  Enable light-weight counting of various locking related events
> -	  in the system with minimal performance impact. This reduces
> -	  the chance of application behavior change because of timing
> -	  differences. The counts are reported via debugfs.
> -
>   # Select if the architecture has support for applying RELR relocations.
>   config ARCH_HAS_RELR
>   	bool
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 2779c29d9981..76639ff5998c 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1401,6 +1401,15 @@ config DEBUG_LOCKING_API_SELFTESTS
>   	  The following locking APIs are covered: spinlocks, rwlocks,
>   	  mutexes and rwsems.
>   
> +config LOCK_EVENT_COUNTS
> +	bool "Locking event counts collection"
> +	depends on DEBUG_FS
> +	help
> +	  Enable light-weight counting of various locking related events
> +	  in the system with minimal performance impact. This reduces
> +	  the chance of application behavior change because of timing
> +	  differences. The counts are reported via debugfs.
> +
>   config LOCK_TORTURE_TEST
>   	tristate "torture tests for locking"
>   	depends on DEBUG_KERNEL

It looks good to me.

Acked-by: Waiman Long <longman@...hat.com>