linux-kernel - Re: [External] [PATCH] linux/memcontrol.h: Remove duplicate struct declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMZfGtVSNVC2zapQPxN-G=Pk6vk2VWa0jf235-Vz8F-zjSTKDQ@mail.gmail.com>
Date:   Tue, 30 Mar 2021 10:13:30 +0800
From:   Muchun Song <songmuchun@...edance.com>
To:     Wan Jiabing <wanjiabing@...o.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Shakeel Butt <shakeelb@...gle.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Roman Gushchin <guro@...com>, Michal Hocko <mhocko@...e.com>,
        Alex Shi <alex.shi@...ux.alibaba.com>,
        Alexander Duyck <alexander.h.duyck@...ux.intel.com>,
        Chris Down <chris@...isdown.name>,
        Yafang Shao <laoar.shao@...il.com>,
        Wei Yang <richard.weiyang@...il.com>,
        LKML <linux-kernel@...r.kernel.org>, kael_w@...h.net
Subject: Re: [External] [PATCH] linux/memcontrol.h: Remove duplicate struct declaration

On Tue, Mar 30, 2021 at 10:03 AM Wan Jiabing <wanjiabing@...o.com> wrote:
>
> struct mem_cgroup is declared twice. One has been declared
> at forward struct declaration. Remove the duplicate.
>
> Signed-off-by: Wan Jiabing <wanjiabing@...o.com>

Reviewed-by: Muchun Song <songmuchun@...edance.com>

Thanks.

> ---
>  include/linux/memcontrol.h | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
> index 0c04d39a7967..f0ae33a0f175 100644
> --- a/include/linux/memcontrol.h
> +++ b/include/linux/memcontrol.h
> @@ -1068,8 +1068,6 @@ void split_page_memcg(struct page *head, unsigned int nr);
>  #define MEM_CGROUP_ID_SHIFT    0
>  #define MEM_CGROUP_ID_MAX      0
>
> -struct mem_cgroup;
> -
>  static inline struct mem_cgroup *page_memcg(struct page *page)
>  {
>         return NULL;
> --
> 2.25.1
>