linux-kernel - Re: [PATCH] firmware: stratix10-svc: extend SVC driver to get the firmware version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16c40de5-b405-92b6-d08f-e395b9774e7e@linux.intel.com>
Date:   Tue, 30 Mar 2021 11:02:46 -0500
From:   Richard Gong <richard.gong@...ux.intel.com>
To:     David Laight <David.Laight@...LAB.COM>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Cc:     "mdf@...nel.org" <mdf@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Richard Gong <richard.gong@...el.com>
Subject: Re: [PATCH] firmware: stratix10-svc: extend SVC driver to get the
 firmware version


Hi David,

On 3/30/21 9:19 AM, David Laight wrote:
> From: richard.gong@...ux.intel.com
>> Sent: 30 March 2021 15:33
>>
>> Extend Intel service layer driver to get the firmware version running at
>> FPGA device. Therefore FPGA manager driver, one of Intel service layer
>> driver's client, can decide whether to handle the newly added bitstream
>> authentication function based on the retrieved firmware version.
> 
> Using the version number to detect features is just plain wrong.
> 
> You should use something like a bitmap of supported features.

Firmware, which runs at EL3, returns the version to Intel service layer 
driver in a 64-bit value at the register. Intel service layer driver 
runs at EL1.

Regards,
Richard

> 
> 	David
> 
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)
>