linux-kernel - RE: [PATCH] firmware: stratix10-svc: extend SVC driver to get the firmware version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <26176a0062114b9faa7c2c64c8ea3e64@AcuMS.aculab.com>
Date:   Tue, 30 Mar 2021 14:19:02 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     "'richard.gong@...ux.intel.com'" <richard.gong@...ux.intel.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     "mdf@...nel.org" <mdf@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Richard Gong <richard.gong@...el.com>
Subject: RE: [PATCH] firmware: stratix10-svc: extend SVC driver to get the
 firmware version

From: richard.gong@...ux.intel.com
> Sent: 30 March 2021 15:33
> 
> Extend Intel service layer driver to get the firmware version running at
> FPGA device. Therefore FPGA manager driver, one of Intel service layer
> driver's client, can decide whether to handle the newly added bitstream
> authentication function based on the retrieved firmware version.

Using the version number to detect features is just plain wrong.

You should use something like a bitmap of supported features.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)