linux-kernel - Re: [PATCH v5 3/5] i2c: add support for HiSilicon I2C controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7efac5e2-aa1c-0575-0e9e-ca4eb659ed3f@gmail.com>
Date:   Tue, 30 Mar 2021 19:32:04 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Yicong Yang <yangyicong@...ilicon.com>, wsa@...nel.org,
        andriy.shevchenko@...ux.intel.com, linux-i2c@...r.kernel.org,
        Sergey.Semin@...kalelectronics.ru, linux-kernel@...r.kernel.org
Cc:     treding@...dia.com, jarkko.nikula@...ux.intel.com,
        rmk+kernel@...linux.org.uk, song.bao.hua@...ilicon.com,
        john.garry@...wei.com, mika.westerberg@...ux.intel.com,
        prime.zeng@...wei.com, linuxarm@...wei.com
Subject: Re: [PATCH v5 3/5] i2c: add support for HiSilicon I2C controller

30.03.2021 19:24, Dmitry Osipenko пишет:
>> +struct hisi_i2c_controller {
>> +	struct i2c_adapter adapter;
>> +	void __iomem *iobase;
>> +	struct device *dev;
>> +	int irq;
>> +
>> +	/* Intermediates for recording the transfer process */
>> +	struct completion *completion;
>> +	struct i2c_msg *msgs;
>> +	int msg_num;
>> +	int msg_tx_idx;
>> +	int buf_tx_idx;
>> +	int msg_rx_idx;
>> +	int buf_rx_idx;
>> +	u16 tar_addr;
>> +	u32 xfer_err;
>> +
>> +	/* I2C bus configuration */
>> +	struct i2c_timings t;
>> +	u64 clk_rate_khz;
> Looks like the u64 is overkill here and it doesn't allow you to use
> COMPILE_TEST because 32bit arches can divide u64 only using the
> do_div(), please fix this.

I see now that the value isn't divided anywhere directly in the code, my
bad. Looks good then.