[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAJZ5v0hg3smHRVQNDDQmq94Ss-WH1xkeYaVZ62JPAUadMZuzFw@mail.gmail.com>
Date: Tue, 30 Mar 2021 21:50:42 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Vitaly Kuznetsov <vkuznets@...hat.com>
Cc: ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
"Rafael J. Wysocki" <rjw@...ysocki.net>,
"the arch/x86 maintainers" <x86@...nel.org>,
Len Brown <lenb@...nel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ACPI: processor: Fix build when !CONFIG_HOTPLUG_CPU
On Tue, Mar 30, 2021 at 12:27 PM Vitaly Kuznetsov <vkuznets@...hat.com> wrote:
>
> Kernel test robot reports build breakage with commit 5f5e49e999ac
> ("ACPI: processor: Fix CPU0 wakeup in acpi_idle_play_dead()") when
> !CONFIG_HOTPLUG_CPU/!CONFIG_SMP. wakeup_cpu0() is defined under
> CONFIG_SMP and start_cpu0() under CONFIG_HOTPLUG_CPU which, in its turn,
> depend on CONFIG_SMP. Add #ifdef CONFIG_HOTPLUG_CPU to the block, this
> should be sufficient.
>
> Reported-by: kernel test robot <lkp@...el.com>
> Fixes: 5f5e49e999ac ("ACPI: processor: Fix CPU0 wakeup in acpi_idle_play_dead()")
Folded into the above patch, thanks!
> Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>
> ---
> drivers/acpi/processor_idle.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
> index f0c73f658880..0925b1477230 100644
> --- a/drivers/acpi/processor_idle.c
> +++ b/drivers/acpi/processor_idle.c
> @@ -539,7 +539,7 @@ static int acpi_idle_play_dead(struct cpuidle_device *dev, int index)
> } else
> return -ENODEV;
>
> -#ifdef CONFIG_X86
> +#if defined(CONFIG_X86) && defined(CONFIG_HOTPLUG_CPU)
> /* If NMI wants to wake up CPU0, start CPU0. */
> if (wakeup_cpu0())
> start_cpu0();
> --
> 2.30.2
>
Powered by blists - more mailing lists